TimeCrafters/timecrafters_configuration_tool_desktop
1
0
Fork 0
mirror of https://github.com/TimeCrafters/timecrafters_configuration_tool_desktop.git synced 2025-12-16 05:42:35 +00:00
Code Issues Projects Releases Wiki Activity

Fixed crash when changing type of variable, fixed integer/long error sticking around when it's no longer a valid error

Browse Source
This commit is contained in:
Cyberarm
2021-09-23 14:38:33 -05:00
parent 34c607d1a1
commit e915cbb72f
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/dialogs/variable_dialog.rb
View File

@@ -19,7 +19,7 @@ module TAC
@type_error.hide @type_error.hide
@var_type = list_box items: [:float, :double, :integer, :long, :string, :boolean], choose: @type ? @type : :double, width: 1.0 do |item| @var_type = list_box items: [:float, :double, :integer, :long, :string, :boolean], choose: @type ? @type : :double, width: 1.0 do |item|
@type = item.value.to_sym @type = item.to_sym
if @type == :boolean if @type == :boolean
@value.hide @value.hide
@@ -84,18 +84,12 @@ module TAC
@name_error.value = "Error: Name cannot be blank or only whitespace." @name_error.value = "Error: Name cannot be blank or only whitespace."
@name_error.show @name_error.show
valid = false valid = false
else
@name_error.value = ""
@name_error.hide
end end
if not @type if not @type
@type_error.value = "Error: Type not set." @type_error.value = "Error: Type not set."
@type_error.show @type_error.show
valid = false valid = false
else
@type_error.value = ""
@type_error.hide
end end
if [:integer, :float, :double, :long].include?(@type) if [:integer, :float, :double, :long].include?(@type)
@@ -121,9 +115,6 @@ module TAC
@value_error.show @value_error.show
valid = false valid = false
end end
else
@value_error.value = ""
@value_error.hide
end end
elsif @type == :string elsif @type == :string
@@ -141,6 +132,13 @@ module TAC
valid = false valid = false
end end
if valid
@value_error.value = ""
@value_error.hide
@type_error.value = ""
@type_error.hide
end
return valid return valid
end end
end end