From 04d40fe8fca3cf6e260b30acf0673961ad82144e Mon Sep 17 00:00:00 2001 From: Cyberarm Date: Sat, 5 Nov 2022 22:36:21 -0500 Subject: [PATCH] Don't use 'IO.popen' when no block is given, use 'system' instead. --- lib/common.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/common.rb b/lib/common.rb index fcd2166..74f508f 100644 --- a/lib/common.rb +++ b/lib/common.rb @@ -81,15 +81,17 @@ class W3DHub status.zero? else - IO.popen(command) do |io| - if block + if block + IO.popen(command, "r") do |io| io.each_line do |line| block&.call(line) end end - end - $CHILD_STATUS.success? + $CHILD_STATUS.success? + else + system(command) + end end end