From cb81a51bfe5a2a0be4b4b290a95ad588d96100d1 Mon Sep 17 00:00:00 2001
From: Cyberarm <matthewlikesrobots@gmail.com>
Date: Sat, 26 Apr 2025 19:45:58 -0500
Subject: [PATCH] Fixed failing to fetch manifests properly

---
 lib/application_manager/task.rb | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/lib/application_manager/task.rb b/lib/application_manager/task.rb
index d8d3976..7ae85e2 100644
--- a/lib/application_manager/task.rb
+++ b/lib/application_manager/task.rb
@@ -208,10 +208,17 @@ class W3DHub
           @manifests << manifest
 
           until(manifest.full?)
-            fetch_manifest("games", app_id, "manifest.xml", manifest.base_version)
-            manifest = load_manifest("games", app_id, "manifest.xml", manifest.base_version)
-            manifests << manifest
+            if fetch_manifest("games", app_id, "manifest.xml", manifest.base_version)
+              manifest = load_manifest("games", app_id, "manifest.xml", manifest.base_version)
+              manifests << manifest
+            else
+              fail!("Failed to retrieve manifest: games:#{app_id}:manifest.xml-#{manifest.base_version}")
+              return []
+            end
           end
+        else
+          fail!("Failed to retrieve manifest: games:#{app_id}:manifest.xml-#{@target_version}")
+          return []
         end
 
         @manifests
@@ -594,12 +601,12 @@ class W3DHub
           package = array.first
         else
           fail!("Failed to fetch manifest package details! (#{category}:#{subcategory}:#{name}:#{version})")
-          return
+          return false
         end
 
         if package.error?
           fail!("Failed to retrieve manifest package details! (#{category}:#{subcategory}:#{name}:#{version})\nError: #{package.error.gsub("-", " ").capitalize}")
-          return
+          return false
         end
 
         if File.exist?(Cache.package_path(category, subcategory, name, version))
@@ -622,6 +629,8 @@ class W3DHub
         end
 
         fail!("Failed to retrieve package: (#{package.category}:#{package.subcategory}:#{package.name}:#{package.version})") unless status_okay
+
+        status_okay
       end
 
       def verify_package(package, &block)